Choose correct local address for targeted IP family #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To connect to the right shard the driver needs to specify the local port. This is only possible by also choosing an IP address family (v4 or v6). The code uses IPv4 by default, unless the user configures a different listen address. This means in the default configuration the Scylla driver is unable to connect to IPv6 addresses with a rather surprising "address not available" error. This commit addresses that surprising behavior by not hard coding a default listen address but instead choosing one based on the IP address family that is being connected to.
|
I wonder if it compiles without IPv6 support enabled on the machine, but that should be rate. Otherwise, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To connect to the right shard the driver needs to specify the local port. This is only possible by also choosing an IP address family (v4 or v6).
The code uses IPv4 by default, unless the user configures a different listen address. This means in the default configuration the Scylla driver is unable to connect to IPv6 addresses with a rather surprising "address not available" error.
This commit addresses that surprising behavior by not hard coding a default listen address but instead choosing one based on the IP address family that is being connected to.